🐛 Fix issue with NAT gateway failing due to EIP already been assigned #1803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
so looks like I broke something when rebasing my branch and fixing a merge conflict. I'll fix the test errors tomorrow. Let's see if there is consensus on the approach. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks @aaroniscode ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Until the code is refactored in #1792 , this PR fixes the NAT gateway issue where creation fails because it assigned an EIP that is already bound to a different NAT gateway. The PR tries to keep the exact same workflow and steps but just batch creates the EIPs before creating the NAT gateways.
Changes/Additions:
Created a
createNatGatewaysfunction that batch creates all the NAT gateways while keeping the createNatGateway function intact as much as possibleChanged
getOrAllocateAddresstogetOrAllocateAddressesto batch find/create all the EIPs before the NAT gateways are createdWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1752
Note I need to test this tomorrow because I had to resolve a merge conflict with the recent NAT gateway status condition code change.