- 
                Notifications
    You must be signed in to change notification settings 
- Fork 636
🐛 Restricts AZ limit to 1 in e2e tests #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| It's not ideal to have most test cases not exercising the default behaviour so if it's better to just increase the timeout, I could update it. | 
| @gab-satchi: The specified target(s) for  
 Use  
 In response to this: 
 Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. | 
| /test pull-cluster-api-provider-aws-e2e | 
| I've been avoiding doing this in favour of fixing up the new e2e tests in #1760 | 
| /retest | 
| /test pull-cluster-api-provider-aws-test | 
    
      
        1 similar comment
      
    
  
    | /test pull-cluster-api-provider-aws-test | 
| I'm going to | 
| /approve | 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
What this PR does / why we need it:
The e2e tests have been failing for a while: https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-cluster-api-provider-aws#periodic-e2e-v1alpha3&width=20
They all seem to hit the 20 minute timeout while waiting for the cluster to reach
InfrastructureReady. One of the recent changes that increased the time needed for an AWScluster to reach ready is the subnet defaulting logic #1721These changes restrict the number of AZs to provision infrastructure to 1. While testing locally, this made an improvement from 12 minutes down to 5 minutes.
Note: We still have a test case that specifies subnets in multiple AZs and validates machines are created appropriately but there is now a gap in e2e testing the defaulting logic.