Skip to content

Conversation

@gab-satchi
Copy link
Member

What this PR does / why we need it:
The e2e tests have been failing for a while: https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-cluster-api-provider-aws#periodic-e2e-v1alpha3&width=20
They all seem to hit the 20 minute timeout while waiting for the cluster to reach InfrastructureReady. One of the recent changes that increased the time needed for an AWScluster to reach ready is the subnet defaulting logic #1721

These changes restrict the number of AZs to provision infrastructure to 1. While testing locally, this made an improvement from 12 minutes down to 5 minutes.
Note: We still have a test case that specifies subnets in multiple AZs and validates machines are created appropriately but there is now a gap in e2e testing the defaulting logic.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2020
@gab-satchi
Copy link
Member Author

It's not ideal to have most test cases not exercising the default behaviour so if it's better to just increase the timeout, I could update it.

@k8s-ci-robot
Copy link
Contributor

@gab-satchi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-integration
  • /test pull-cluster-api-provider-aws-verify
  • /test pull-cluster-api-provider-aws-make-conformance
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-conformance

Use /test all to run the following jobs:

  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-integration
  • pull-cluster-api-provider-aws-verify

In response to this:

/test periodic-cluster-api-provider-aws-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gab-satchi
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@randomvariable
Copy link
Member

I've been avoiding doing this in favour of fixing up the new e2e tests in #1760

@randomvariable
Copy link
Member

/retest

@randomvariable
Copy link
Member

/test pull-cluster-api-provider-aws-test

1 similar comment
@randomvariable
Copy link
Member

/test pull-cluster-api-provider-aws-test

@randomvariable
Copy link
Member

I'm going to
/lgtm
this and open an issue to restore the defaults when we have time to sort it out.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2020
@detiber
Copy link
Contributor

detiber commented Jul 7, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 040406e into kubernetes-sigs:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants