Skip to content

Conversation

@enxebre
Copy link
Member

@enxebre enxebre commented Jul 20, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 20, 2018
@detiber
Copy link
Contributor

detiber commented Jul 20, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2018
@detiber
Copy link
Contributor

detiber commented Jul 20, 2018

bump to see if prow picks up on this now.

@detiber
Copy link
Contributor

detiber commented Jul 20, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2018
@detiber
Copy link
Contributor

detiber commented Jul 20, 2018

/test all

@k8s-ci-robot k8s-ci-robot merged commit f4e440b into kubernetes-sigs:master Jul 20, 2018
enxebre pushed a commit to enxebre/cluster-api-provider-aws-2 that referenced this pull request Sep 28, 2018
…me-with-docker-build-issue-in-rh

Mention the docker build does not work with RH docker, imagebuilder as its replacement
chrischdi pushed a commit to chrischdi/cluster-api-provider-aws that referenced this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants