This repository was archived by the owner on Sep 30, 2020. It is now read-only.
Introduce Glide for vendor package management #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose for doing this is to:
1. remove a fairly large number of unimported packages in vendor/
```
$ git status | grep "new file" | wc -l
631
$ git status | grep "modified" | wc -l
543
$ git status | grep "deleted:" | wc -l
3583
```
2. provide developers a unified way to update packages
3. update vendor with latest packages
Also note that I've chosen glide over trash, godep, govendor, etc., because glide:
* seemed well-maintained,
* is used in other coreos products like clair and etcd,
* prunes enough files(e.g. glide only vendors packages imported from non-test go sources, but not too aggressive according to the fast it doesn't flatten nested vendor/ directories or remove *_test.go)
|
build passed as can be seen in https://travis-ci.org/mumoshu/kube-aws/builds/169145557 |
redbaron
referenced
this pull request
in HotelsDotCom/kube-aws
Apr 6, 2017
…avour * commit 'c1f897b642813071a81b452b315badc99bb4fd70': RUN-409: Add deployment to push kubernetes resources up to S3.
Closed
tyrannasaurusbanks
pushed a commit
to tyrannasaurusbanks/kube-aws
that referenced
this pull request
Sep 14, 2018
…sible-tiller-rbac Tiller deploy sensible RBAC rules
dominicgunn
added a commit
that referenced
this pull request
Sep 16, 2020
* KIAM updates to support assumeRoleArn functionalilty * Add compute.internal to etcd san when using private zones, because the aws controller does not support private zones * Fix tests * Forced rebuild. Co-authored-by: Dominic Gunn <[email protected]> Co-authored-by: Dominic Gunn <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose for doing this is to:
remove a fairly large number of unimported packages in vendor/
provide developers a unified way to update packages
(3) update vendor with latest packages
I've chosen glide over trash, godep, govendor, etc., because glide seemed well-maintained, used in other coreos products like clair and etcd, prune enough files(e.g. glide only vendors packages imported from non-test go sources, but not too aggressive according to the fast it doesn't flatten nested vendor/ directories or remove *_test.go)