Skip to content

Conversation

@carlory
Copy link
Member

@carlory carlory commented Jan 13, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

promote HonorPVReclaimPolicy to GA

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#2644

Special notes for your reviewer:

/hold
until kubernetes/kubernetes#129583 is merged.

Does this PR introduce a user-facing change?:

Promoted the feature gate `HonorPVReclaimPolicy` to GA.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 13, 2025
@carlory
Copy link
Member Author

carlory commented Jan 13, 2025

/cc @deepakkinni @xing-yang

@xing-yang
Copy link
Contributor

/assign @deepakkinni

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, deepakkinni, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2025
@carlory
Copy link
Member Author

carlory commented Feb 28, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit d1a05c4 into kubernetes-csi:master Feb 28, 2025
8 checks passed
@carlory carlory deleted the promote-HonorPVReclaimPolicy-GA branch February 28, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants