Skip to content

JUnit fixes #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 17, 2022
Merged

JUnit fixes #214

merged 3 commits into from
Dec 17, 2022

Conversation

@pohly
Copy link
Contributor

@pohly pohly commented Dec 17, 2022

pohly added 3 commits December 17, 2022 17:42
@pohly
prow.sh: publish individual JUnit files as separate artifacts
38e1146 
"junit/steps/junit_*.xml" contains the summary JUnit file of each step (sanity,
make_test, etc.). The original files as written by the e2e.test binary are
under "junit/<name>" where name is "parallel", "serial", etc.

This makes it possible to look up information that might get lost during the
transformation with filter-junit.go and debug that command.
@pohly
filter-junit.go: preserve system error log
d427783 
Ginkgo v2 uses "system-err" to represent the log output of a test. This only
matters for failed tests, but for those it is important to preserve that
information.
@pohly
filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit
b9b6763 
The "junit" variable is meant to accumulate all testcases from the input
files. Overwriting it with the content of an input file when that input file
used the new Ginkgo V2 JUnit caused the result of prior input files to get
lost.
@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 17, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 17, 2022
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xing-yang
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit b66c082 into kubernetes-csi:master Dec 17, 2022
@pohly pohly mentioned this pull request Dec 17, 2022
Merged
pohly added a commit to pohly/csi-driver-host-path that referenced this pull request Dec 17, 2022
@pohly
Squashed 'release-tools/' changes from 78c0fb7..b66c082
51c9db1 
kubernetes-csi/csi-release-tools@b66c0824 Merge kubernetes-csi/csi-release-tools#214 from pohly/junit-fixes
kubernetes-csi/csi-release-tools@b9b6763b filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit
kubernetes-csi/csi-release-tools@d4277839 filter-junit.go: preserve system error log
kubernetes-csi/csi-release-tools@38e11468 prow.sh: publish individual JUnit files as separate artifacts

git-subtree-dir: release-tools
git-subtree-split: b66c082
jsafrane added a commit to jsafrane/external-attacher that referenced this pull request Jan 2, 2023
@jsafrane
Squashed 'release-tools/' changes from e4dab7ff..a2171bef
eceb626 
kubernetes-csi/csi-release-tools@a2171bef Merge kubernetes-csi/csi-release-tools#216 from msau42/process
kubernetes-csi/csi-release-tools@cb987826 Merge kubernetes-csi/csi-release-tools#217 from msau42/owners
kubernetes-csi/csi-release-tools@a11216e4 add new reviewers and remove inactive reviewers
kubernetes-csi/csi-release-tools@dd986754 Add step for checking builds
kubernetes-csi/csi-release-tools@b66c0824 Merge kubernetes-csi/csi-release-tools#214 from pohly/junit-fixes
kubernetes-csi/csi-release-tools@b9b6763b filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit
kubernetes-csi/csi-release-tools@d4277839 filter-junit.go: preserve system error log
kubernetes-csi/csi-release-tools@38e11468 prow.sh: publish individual JUnit files as separate artifacts
kubernetes-csi/csi-release-tools@78c0fb71 Merge kubernetes-csi/csi-release-tools#208 from jsafrane/skip-selinux
kubernetes-csi/csi-release-tools@36e433e2 Skip SELinux tests in CI by default
kubernetes-csi/csi-release-tools@348d4a92 Merge kubernetes-csi/csi-release-tools#207 from RaunakShah/reviewers
kubernetes-csi/csi-release-tools@1efc2724 Merge kubernetes-csi/csi-release-tools#206 from RaunakShah/update-prow
kubernetes-csi/csi-release-tools@7d410d88 Changes to csi prow to run e2e tests in sidecars
kubernetes-csi/csi-release-tools@cfa5a75c Merge kubernetes-csi/csi-release-tools#203 from humblec/test-vendor
kubernetes-csi/csi-release-tools@4edd1d8a Add RaunakShah to CSI reviewers group
kubernetes-csi/csi-release-tools@7ccc9594 release tools update to 1.19
kubernetes-csi/csi-release-tools@d24254f6 Merge kubernetes-csi/csi-release-tools#202 from xing-yang/kind_0.14.0
kubernetes-csi/csi-release-tools@0faa3fc7 Update to Kind v0.14.0 images
kubernetes-csi/csi-release-tools@ef4e1b2b Merge kubernetes-csi/csi-release-tools#201 from xing-yang/add_1.24_image
kubernetes-csi/csi-release-tools@4ddce251 Add 1.24 Kind image
kubernetes-csi/csi-release-tools@7fe51491 Merge kubernetes-csi/csi-release-tools#200 from pohly/bump-kubernetes-version
kubernetes-csi/csi-release-tools@70915a8e prow.sh: update snapshotter version
kubernetes-csi/csi-release-tools@31a3f38b Merge kubernetes-csi/csi-release-tools#199 from pohly/bump-kubernetes-version
kubernetes-csi/csi-release-tools@7577454a prow.sh: bump Kubernetes to v1.22.0
kubernetes-csi/csi-release-tools@d29a2e75 Merge kubernetes-csi/csi-release-tools#198 from pohly/csi-test-5.0.0
kubernetes-csi/csi-release-tools@41cb70d3 prow.sh: sanity testing with csi-test v5.0.0
kubernetes-csi/csi-release-tools@c85a63fb Merge kubernetes-csi/csi-release-tools#197 from pohly/fix-alpha-testing
kubernetes-csi/csi-release-tools@b86d8e94 support Kubernetes 1.25 + Ginkgo v2
kubernetes-csi/csi-release-tools@ab0b0a3d Merge kubernetes-csi/csi-release-tools#192 from andyzhangx/patch-1
kubernetes-csi/csi-release-tools@7bbab24e Merge kubernetes-csi/csi-release-tools#196 from humblec/non-alpha
kubernetes-csi/csi-release-tools@e51ff2cc introduce control variable for non alpha feature gate configuration
kubernetes-csi/csi-release-tools@ca19ef52 Merge kubernetes-csi/csi-release-tools#195 from pohly/fix-alpha-testing
kubernetes-csi/csi-release-tools@3948331e fix testing with latest Kubernetes
kubernetes-csi/csi-release-tools@9a0260c5 fix boilerplate header

git-subtree-dir: release-tools
git-subtree-split: a2171bef02a0d4e469e2f48918570f5c76e0deea
@jsafrane jsafrane mentioned this pull request Jan 2, 2023
Merged
@chrishenzie chrishenzie mentioned this pull request Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@Jiawei0227 Jiawei0227 Awaiting requested review from Jiawei0227

Assignees

@xing-yang xing-yang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pohly @xing-yang @k8s-ci-robot