Skip to content

Replace wmic with PowerShell's Get-CimInstance cmdlet #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

Replace wmic with PowerShell's Get-CimInstance cmdlet #407

merged 1 commit into from
Sep 16, 2025
+7 −9

Conversation

mauriciopoppe
Copy link
Member

@mauriciopoppe mauriciopoppe commented Sep 13, 2025 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind failing-test

What this PR does / why we need it:

Replace wmic with PowerShell's Get-CimInstance cmdlet. wmic is deprecated and might have stopped working in the github actions worker.

Does this PR introduce a user-facing change?:

NONE

/cc @laozc

@k8s-ci-robot k8s-ci-robot requested a review from laozc September 13, 2025 15:58
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2025
@mauriciopoppe
Copy link
Member Author

/retest

@mauriciopoppe
Copy link
Member Author

/retest-required

@mauriciopoppe
Copy link
Member Author

/cc @andyzhangx

andyzhangx
andyzhangx approved these changes Sep 16, 2025
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andyzhangx,mauriciopoppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e12aec6 into kubernetes-csi:master Sep 16, 2025
12 checks passed
@mauriciopoppe mauriciopoppe deleted the presubmit-bios-error branch September 17, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@laozc laozc Awaiting requested review from laozc

Assignees

@andyzhangx andyzhangx

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mauriciopoppe @k8s-ci-robot @andyzhangx