Skip to content

chore: Bump release-tools #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2025
Merged

chore: Bump release-tools #395

merged 2 commits into from
Jul 11, 2025
+14 −14

Conversation

laozc
Copy link
Member

@laozc laozc commented Jul 10, 2025

What type of PR is this?
/kind chore

What this PR does / why we need it:
Bump release-tools to use Go 1.24 for newer microsoft/wmi.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

laozc added 2 commits July 10, 2025 20:43
@laozc
Squashed 'release-tools/' changes from 98f2307..74e066a
03d6401 
74e066a Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be Update CSI prow driver version to v1.17.0
0ee5589 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af1015 update to go 1.24.4
f5fec3e Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285d Remove chrishenzie from kubernetes-csi-reviewers
0a435bf Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bb Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34 Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30 Bump golang to 1.24.0
f277d56 Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2c Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fe Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a update default kind version to v0.25.0
0496593 Merge pull request kubernetes-csi#268 from huww98/cloudbuild
119aee1 Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1
0ae5e52 Update cloudbuild image with go 1.21+
406a79a Merge pull request kubernetes-csi#267 from huww98/gomodcache
9cec273 Set GOMODCACHE to avoid re-download toolchain
43bde06 Bump csi-sanity to 5.3.1

git-subtree-dir: release-tools
git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
@laozc
Merge commit '03d6401aff39038bb1a99322713653102f017db2' into bump-rel…
10a9ab4 
…ease-tools
@k8s-ci-robot
Copy link
Contributor

@laozc: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind chore

What this PR does / why we need it:
Bump release-tools to use Go 1.24 for newer microsoft/wmi.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 10, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @laozc. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 10, 2025
@mauriciopoppe
Copy link
Member

This is blocked by #361.

@laozc
Copy link
Member Author

laozc commented Jul 11, 2025 •
edited
Loading

@mauriciopoppe I believe the code should handle the symlink correctly regardless of the Go version after #393 gets merged.

We also have https://github.com/kubernetes-csi/csi-proxy/pull/394/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R8 as part of bumping latest microsoft/wmi

cc @andyzhangx

andyzhangx
andyzhangx approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, laozc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 50ac1fc into kubernetes-csi:master Jul 11, 2025
8 checks passed
@mauriciopoppe
Copy link
Member

mauriciopoppe commented Jul 11, 2025 •
edited
Loading

I'm surprised that this passed given the check that I added here to build the project with go <=1.22 only

csi-proxy/Makefile

Line 19 in 50ac1fc

if (( "$$(go version | awk '{print $3}' | sed 's/go//' | cut -d'.' -f2)" > 22 )); then echo "This project requires go 1.22 or lower"; exit 1; fi;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laozc @k8s-ci-robot @mauriciopoppe @andyzhangx