-
Notifications
You must be signed in to change notification settings - Fork 62
feat: Use WMI to implement iSCSI API to reduce PowerShell overhead #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use WMI to implement iSCSI API to reduce PowerShell overhead #377
Conversation
Hi @laozc. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
8180563
to
23fdc35
Compare
6e9146e
to
bc55567
Compare
bc55567
to
ddd12ba
Compare
ddd12ba
to
5c60a2f
Compare
@andyzhangx Is Azure driver using iSCSI API? Could you verify this API as well? |
Seems like Azuredisk doesn't use ISCSI https://github.com/search?q=repo%3Akubernetes-sigs%2Fazuredisk-csi-driver%20iscsi&type=code |
fd53815
to
dfb404a
Compare
65a3c9f
to
b5025b7
Compare
b5025b7
to
6556808
Compare
6556808
to
889967b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm minus a comment about errors
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laozc, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR leverages of WMI interfaces to replace the PowerShell functions for System APIs,
It improves the overall performance of csi-proxy.
Partially for #193
Which issue(s) this PR fixes:
Special notes for your reviewer:
This is part of serial changes for #193 breaking into per-API change.
Does this PR introduce a user-facing change?: