-
Notifications
You must be signed in to change notification settings - Fork 62
Set up a metrics server with data served on /metrics #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @laozc. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I left a few comments.
974e701
to
8adf0cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments.
/ok-to-test
8adf0cf
to
536ab0d
Compare
65686bb
to
1d2293d
Compare
fdca099
to
8dc99b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote a few comments in the setup of the server and on inlining the code. The approach looks good to me, thanks.
Thanks a lot for the implementation! I thought we could port the implementation to the library-development branch but I think it's not applicable because the gRPC metrics would already be exposed as part of the CSI Driver metrics (once the CSI Driver uses the library implementation). /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laozc, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Expose gRPC prometheus metrics to capture performance for volume operations
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: