Skip to content

Automated cherry pick of #369: Revert "Add min go runtime to be 1.23 and add godebug #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Automated cherry pick of #369: Revert "Add min go runtime to be 1.23 and add godebug #370

wants to merge 1 commit into from
+5 −7

Conversation

mauriciopoppe
Copy link
Member

@mauriciopoppe mauriciopoppe commented Feb 11, 2025 •
edited
Loading

Cherry pick of #369 on release-1.2.

/kind feature

#369: Revert "Add min go runtime to be 1.23 and add godebug

For details on the cherry pick process, see the cherry pick requests page.

Revert using go 1.23 + compat flags to go 1.20 in go.mod

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 11, 2025
@mauriciopoppe
Copy link
Member Author

/uncc @gnufied @RaunakShah
/cc @msau42 @sunnylovestiramisu

@k8s-ci-robot k8s-ci-robot requested review from msau42 and sunnylovestiramisu and removed request for gnufied and RaunakShah February 11, 2025 01:12
@mauriciopoppe mauriciopoppe force-pushed the automated-cherry-pick-of-#369-upstream-release-1.2 branch from 958d19f to 88f3542 Compare February 11, 2025 01:13
@mauriciopoppe
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@mauriciopoppe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-csi-proxy-integration 88f3542 link true /test pull-kubernetes-csi-csi-proxy-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mauriciopoppe
Copy link
Member Author

I'll redo this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauriciopoppe @k8s-ci-robot