-
Couldn't load subscription status.
- Fork 32
support device with multiple targets #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support device with multiple targets #13
Conversation
Signed-off-by: Lou <[email protected]>
|
Welcome @27149chen! |
|
/assign @j-griffith |
|
/assign @saad-ali |
Signed-off-by: Lou <[email protected]>
Signed-off-by: Lou <[email protected]>
|
@j-griffith , Thank you very much for your review, I updated the code according to your comments, please have another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
|
@j-griffith , I need an "approve" label from you to merge this pr, I guess you forgot to add it :) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 27149chen, j-griffith The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Some storage systems have multiple iscsi targets to support multipath devices, A Connector stands for a device, so we should support this situation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
move targetIqn and protals out of Connector as an individual struct, it is an iqn-portal pair, support one iqn to multiple portals and multiple iqns to multiple portals.
Does this PR introduce a user-facing change?: