Skip to content

Conversation

@27149chen
Copy link

@27149chen 27149chen commented Dec 13, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Some storage systems have multiple iscsi targets to support multipath devices, A Connector stands for a device, so we should support this situation.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
move targetIqn and protals out of Connector as an individual struct, it is an iqn-portal pair, support one iqn to multiple portals and multiple iqns to multiple portals.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 13, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @27149chen!

It looks like this is your first PR to kubernetes-csi/csi-lib-iscsi 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-lib-iscsi has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 13, 2019
@27149chen
Copy link
Author

/assign @j-griffith

@27149chen
Copy link
Author

/assign @saad-ali

@27149chen
Copy link
Author

@j-griffith , Thank you very much for your review, I updated the code according to your comments, please have another look.

Copy link

@j-griffith j-griffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2019
@27149chen
Copy link
Author

27149chen commented Dec 24, 2019

@j-griffith , I need an "approve" label from you to merge this pr, I guess you forgot to add it :)

@j-griffith
Copy link

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 27149chen, j-griffith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1efb74c into kubernetes-csi:master Jan 6, 2020
@27149chen 27149chen deleted the support_device_with_multiple_targets branch January 7, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants