Skip to content

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Dec 14, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tg123
To complete the pull request process, please assign krabhishek8260
You can assign the PR to them by writing /assign @krabhishek8260 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 14, 2019
@tg123
Copy link
Member Author

tg123 commented Dec 16, 2019

gitversion should work with dotnet 3, still looking into it

@brendandburns
Copy link
Contributor

I think I want to hold off on merging this because in theory 1.17 clients aren't required to be compatible with 1.14 clusters and I think at this point 1.14 clusters are more common than 1.17 clusters...

@tg123 tg123 force-pushed the gen_v1.17.0 branch 2 times, most recently from 21fde7f to 8671f93 Compare March 15, 2020 00:13
tg123 added 2 commits March 17, 2020 14:32
align version with k8s upstream
@tg123 tg123 closed this Apr 11, 2020
@tg123 tg123 deleted the gen_v1.17.0 branch October 30, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants