Skip to content

Enable config drive for open stack #7516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

Enable config drive for open stack #7516

merged 1 commit into from
Jul 31, 2025

Conversation

@ahmadhamzh
Copy link
Contributor

@ahmadhamzh ahmadhamzh commented Jul 30, 2025 •
edited
Loading

What this PR does / why we need it:
Add a new checkbox to enable the config drive for MD in the OpenStack provider, and also add an option at the datacenter level to enforce enabling it on all MDs.

image image

Which issue(s) this PR fixes:
Fixes #6733

What type of PR is this?
/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Added a new option to enable the config drive on the OpenStack provider for machine deployments, along with a datacenter-level option to enforce it for all machine deployments.

Documentation:

https://github.com/kubermatic/docs/pull/2019

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2025
@ahmadhamzh ahmadhamzh changed the title Enable of cloud drive for open stack Enable of config drive for open stack Jul 30, 2025
@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 30, 2025
@ahmadhamzh ahmadhamzh changed the title Enable of config drive for open stack WIP Enable of config drive for open stack Jul 30, 2025
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2025
@ahmadhamzh ahmadhamzh force-pushed the 6733-enable-of-cloud-drive-for-OpenStack branch from 53c96fe to 8c7a440 Compare July 30, 2025 11:39
@ahmadhamzh ahmadhamzh changed the title WIP Enable of config drive for open stack Enable of config drive for open stack Jul 30, 2025
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2025
@ahmadhamzh ahmadhamzh added the backport-needed Denotes a PR or issue that has not been fully backported. label Jul 30, 2025
Waseem826
Waseem826 requested changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback. PTAL

modules/web/src/app/settings/admin/limits/template.html
Copy link
Contributor

@Waseem826 Waseem826 Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes in this file too because of backport reasons.

@ahmadhamzh ahmadhamzh force-pushed the 6733-enable-of-cloud-drive-for-OpenStack branch from 8c7a440 to 4f5538c Compare July 31, 2025 11:42
@ahmadhamzh ahmadhamzh requested a review from Waseem826 July 31, 2025 11:51
@ahmadhamzh ahmadhamzh force-pushed the 6733-enable-of-cloud-drive-for-OpenStack branch 2 times, most recently from 42ed8fa to 04d964d Compare July 31, 2025 13:16
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2025
@ahmadhamzh
Copy link
Contributor Author

ahmadhamzh commented Jul 31, 2025

/cherry-pick release/v2.28
/cherry-pick release/v2.27
/cherry-pick release/v2.26

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jul 31, 2025

@ahmadhamzh: once the present PR merges, I will cherry-pick it on top of release/v2.26, release/v2.27, release/v2.28 in new PRs and assign them to you.

In response to this:

/cherry-pick release/v2.28
/cherry-pick release/v2.27
/cherry-pick release/v2.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahmadhamzh ahmadhamzh force-pushed the 6733-enable-of-cloud-drive-for-OpenStack branch from 04d964d to 99f6af7 Compare July 31, 2025 15:09
Waseem826
Waseem826 approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jul 31, 2025

LGTM label has been added.

Git tree hash: 7d2a15a77752a75a4948e8a33f4f778d17c03858

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jul 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2025
@kubermatic-bot kubermatic-bot merged commit 5656123 into kubermatic:main Jul 31, 2025
8 of 10 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.29 milestone Jul 31, 2025
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jul 31, 2025

@ahmadhamzh: new pull request created: #7517

In response to this:

/cherry-pick release/v2.28
/cherry-pick release/v2.27
/cherry-pick release/v2.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Jul 31, 2025
Merged
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jul 31, 2025

@ahmadhamzh: new pull request created: #7518

In response to this:

/cherry-pick release/v2.28
/cherry-pick release/v2.27
/cherry-pick release/v2.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Jul 31, 2025
Merged
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jul 31, 2025

@ahmadhamzh: new pull request created: #7519

In response to this:

/cherry-pick release/v2.28
/cherry-pick release/v2.27
/cherry-pick release/v2.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Jul 31, 2025
Merged
@Waseem826 Waseem826 changed the title Enable of config drive for open stack Enable config drive for open stack Aug 4, 2025
@csengerszabo csengerszabo mentioned this pull request Sep 11, 2025
Closed
@ahmadhamzh ahmadhamzh mentioned this pull request Oct 27, 2025
Open
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

Assignees

@Waseem826 Waseem826

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-needed Denotes a PR or issue that has not been fully backported. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

KKP 2.29

Development

Successfully merging this pull request may close these issues.

Enablement of cloud drive for OpenStack in KKP UI

3 participants

@ahmadhamzh @kubermatic-bot @Waseem826