KTOR-5850 Fix SendCountExceedException in HttpRequestRetry

[marychatte]

Subsystem
Client, HttpRequestRetry

Motivation
KTOR-5850

Solution
HttpSend plugin has its own counter for attempts, and the default value is 20. Users can configure it:

install(HttpSend) {
    maxSendCount = 25
}

HttpRequestRetry plugin also has its own value maxRetries, which can be bigger than 20. The solution is to use HttpRequestRetry.maxRetries for HttpSend if it's configured

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch marychatte/KTOR-5850-HttpRequestRetry-SendCountExceedException-when-max-retries-is-more-than-maxSendCount-of-HttpSend

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[bjhham]

Let's change this println into an assert 👀