Skip to content

KTOR-6610: feat: add debug log of ConfigLoader when server starts #5140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −2
Open

KTOR-6610: feat: add debug log of ConfigLoader when server starts #5140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions ktor-server/ktor-server-core/common/src/io/ktor/server/config/ConfigLoaders.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@

package io.ktor.server.config

import io.ktor.util.logging.*

internal expect val CONFIG_PATH: List<String>

private val logger = KtorSimpleLogger("io.ktor.server.config.ConfigLoader")

/**
* Loads an application configuration.
* An implementation of this interface should return [ApplicationConfig] if applicable configuration is found
Expand Down Expand Up @@ -51,23 +55,34 @@ public interface ConfigLoader {
*/
public fun load(path: String? = null): ApplicationConfig {
if (path == null) {
logger.debug("Loading default configuration")
val default = loadDefault()
if (default != null) return default
}

for (loader in configLoaders) {
logger.debug("Trying ConfigLoader: ${loader::class.simpleName}")
val config = loader.load(path)
if (config != null) return config
if (config != null) {
logger.debug("Configuration loaded successfully using ${loader::class.simpleName} from path: $path")
return config
}
}

logger.debug("No configuration found, using empty MapApplicationConfig")
return MapApplicationConfig()
}

private fun loadDefault(): ApplicationConfig? {
for (defaultPath in CONFIG_PATH) {
logger.debug("Trying default config path: $defaultPath")
for (loader in configLoaders) {
logger.debug("Trying ConfigLoader: ${loader::class.simpleName} for path: $defaultPath")
val config = loader.load(defaultPath)
if (config != null) return config
if (config != null) {
logger.debug("Default configuration loaded using ${loader::class.simpleName} from path: $defaultPath")
return config
}
}
}

Expand Down