Adding 'deep' option in order to compare while ignoring whitespace in text nodes #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2014 22:25
…noring whitespace at the begining and end of the text nodes
|
I'll review and merge that |
|
published in 0.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, currently an XML like:
won't be equal to
So I just added the option to use the 'deep' flag in order to ignore whitespace at the beginning and end of the text nodes. It is done just setting to true the trim option in the xml2js parser.
Now, you can use expect(formattedXml).xml.to.deep.equal(unformattedXml) in order to ignore the whitespace or keep using expect(formattedXml).xml.to.not.equal(unformattedXml) in order to taking it into account.