Prevent it from working on TL5 #63
Conversation
|
👍 |
|
|
||
| gem.add_dependency 'railties', '>= 3.1.0' | ||
| gem.add_dependency 'turbolinks' | ||
| gem.add_dependency 'turbolinks', '< 4' |
There was a problem hiding this comment.
V4 doesn't exist haha
On Mon, Jul 18, 2016, 12:34 PM Aleksey Ivanov [email protected]
wrote:
In jquery-turbolinks.gemspec
#63 (comment)
:@@ -25,5 +25,5 @@ Gem::Specification.new do |gem|
gem.rubygems_version = '1.8.15'gem.add_dependency 'railties', '>= 3.1.0'
- gem.add_dependency 'turbolinks'
- gem.add_dependency 'turbolinks', '< 4'
Why is it not < 5?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kossnocorp/jquery.turbolinks/pull/63/files/c40b554104c85b67df632d079d82993beb91563f#r71099904,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEikVp6qPS7fLY_xKuymjXVxGPccBKAks5qWwJVgaJpZM4JOYX4
.
There was a problem hiding this comment.
So as V3)
I added < 5 and it installed 2.1.0 (if I remember right).
UPDATE 1
rubygems says last non5 version is 2.5.3.
UPDATE 2
I was wrong.
gem 'turbolinks', '< 5' installed 2.5.3 as it should be.
|
Can this be merged and a new version released? |
|
@rstacruz can you merge the PR? |
As noted in many issues (#61 #62), Turbolinks 5 isn't supported.