Skip to content

Rework the modeling of install actions and report failures #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2023
Merged

Rework the modeling of install actions and report failures #25

merged 2 commits into from
Sep 27, 2023

Conversation

@haboustak
Copy link
Collaborator

@haboustak haboustak commented Mar 5, 2023 •
edited
Loading

The InstallAction class encapsulates the context required for the match and translate operations. This makes it possible to report detailed errors when a user-requested install didn't match any input files.

The following artifacts.lock.yml:

- install:
    arm-linux-musleabi.tar.zst: artifacts/toolchain/arm-linux-musleabi.tar.zst
    i686-linux-musl.tar.zst: artifacts/toolchain/i686-linux-musl.tar.zst
    aarch64-linux-musl.tar.zst: artifacts/toolchain/aarch64-linux-musl.tar.zst
    x86_64-linux-musl.tar.zst: artifacts/toolchain/x86_64-linux-musl.tar.zst
  job: aarch64
  job_id: 318197
  project: musl-cross-make
  ref: v1.0.2

With the following archive content:

   Date      Time    Attr         Size   Compressed  Name
------------------- ----- ------------ ------------  ------------------------
2022-08-26 05:59:51 .....     54988828     54954241  aarch64-linux-musl.tar.zst
2022-08-26 05:59:50 .....     15890447      1223336  build.log
------------------- ----- ------------ ------------  ------------------------
2022-08-26 05:59:51           70879275     56177577  2 files

Produces this output:

$ art install
* install: aarch64-linux-musl.tar.zst => artifacts/toolchain/aarch64-linux-musl.tar.zst   -rw-r--r--
Error: Source path(s) did not match any files/non-empty directories in the archive:
  archive: /home/mike/.cache/art/musl-cross-make/318197.zip
  project: musl-cross-make
  job: aarch64 (318197)
  ref: v1.0.2
    arm-linux-musleabi.tar.zst => artifacts/toolchain/arm-linux-musleabi.tar.zst
    i686-linux-musl.tar.zst => artifacts/toolchain/i686-linux-musl.tar.zst
    x86_64-linux-musl.tar.zst => artifacts/toolchain/x86_64-linux-musl.tar.zst

@haboustak haboustak force-pushed the 23-raise-exception-on-missing-files branch 4 times, most recently from e5078e3 to 7dabfbb Compare March 8, 2023 02:52
haboustak
haboustak commented Sep 18, 2023
View reviewed changes
@haboustak haboustak force-pushed the 23-raise-exception-on-missing-files branch 2 times, most recently from df3c66c to 2b73836 Compare September 23, 2023 10:47
haboustak
haboustak commented Sep 23, 2023
View reviewed changes
@haboustak haboustak force-pushed the 23-raise-exception-on-missing-files branch from 2b73836 to 6c8a485 Compare September 24, 2023 14:12
@haboustak
Rework the modeling of install actions and report failures
15d856b 
The InstallAction class encapsulates the context required for the match
and translate operations. This makes it possible to report detailed errors
when a user-requested install didn't match any input files.

Fixes kosma#23
@haboustak
Remove directory filter when installing
42a18b4 
Processing every zipfile member might be slightly slower, but if an
empty directory matches an install source specification it should be
installed.

Fixes kosma#24
@haboustak haboustak force-pushed the 23-raise-exception-on-missing-files branch from 6c8a485 to 42a18b4 Compare September 24, 2023 14:37
@haboustak haboustak merged commit fe971be into kosma:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@haboustak