Skip to content

Conversation

@preschian
Copy link
Member

@preschian preschian commented Dec 12, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • fix Prefer function slots for better performance. probably will open PR on polkadot/vue-identicon later
  • fix unused imports
  • fix reserved props

@cloudflare-workers-and-pages
Copy link

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: edb4a0e
Status: ✅  Deploy successful!
Preview URL: https://9821bf65.kodaart-production.pages.dev
Branch Preview URL: https://fix--warning-messages.kodaart-production.pages.dev

View logs

@netlify
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit edb4a0e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/675af0731309f700083b54c9
😎 Deploy Preview https://deploy-preview-11246--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud
Copy link

@socket-security
Copy link

@preschian preschian marked this pull request as ready for review December 12, 2024 14:25
@preschian preschian requested a review from a team as a code owner December 12, 2024 14:25
@preschian preschian requested review from Jarsen136 and hassnian and removed request for a team December 12, 2024 14:25
@preschian preschian added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit af243fd Dec 13, 2024
24 checks passed
@preschian preschian deleted the fix--warning-messages branch December 13, 2024 11:06
@vikiival
Copy link
Member

vikiival commented Dec 13, 2024

@preschian is there any link where can I find this?

Prefer function slots for better performance

@preschian
Copy link
Member Author

@preschian is there any link where can I find this?

Prefer function slots for better performance

Vue.js repos helped me discover that.

- https://github.com/vuejs/test-utils/issues/512
- https://github.com/vuejs/test-utils/blob/96ef276735ce188f50daa2b4143b80a4d716a44d/tests/element.spec.ts#L89-L100
- https://github.com/vuejs/test-utils/blob/96ef276735ce188f50daa2b4143b80a4d716a44d/tests/element.spec.ts#L109-L122

Finally, I can enable warning messages again during development. Previously, I always had to disable warning messages because we were getting flooded by them due to our extensive use of identicon components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants