Skip to content

fix generateModelOpenClasses := true in scala #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2021
Merged

fix generateModelOpenClasses := true in scala #741

merged 2 commits into from
Jul 5, 2021

Conversation

@jxnu-liguobin
Copy link
Collaborator

@jxnu-liguobin jxnu-liguobin commented Jul 3, 2021

Description

Related to #ISSUE_NUMBER

when use generateModelOpenClasses in scala, Add val before field declare.

Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala
  • Maven plugin
  • Gradle plugin
  • SBT plugin

@jxnu-liguobin jxnu-liguobin requested a review from kobylynskyi July 3, 2021 10:06
@jxnu-liguobin jxnu-liguobin self-assigned this Jul 3, 2021
@jxnu-liguobin jxnu-liguobin added bug Something isn't working scala Pull requests that update Scala code labels Jul 3, 2021
@jxnu-liguobin jxnu-liguobin linked an issue Jul 3, 2021 that may be closed by this pull request
[Scala] Setting generateModelOpenClasses := true will lead to compile failure #583
Closed
kobylynskyi
kobylynskyi approved these changes Jul 5, 2021
View reviewed changes
Copy link
Owner

@kobylynskyi kobylynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kobylynskyi kobylynskyi merged commit fb17635 into kobylynskyi:develop Jul 5, 2021
@kbrooks kbrooks mentioned this pull request Aug 13, 2021
Merged
6 tasks
@kobylynskyi kobylynskyi mentioned this pull request Sep 4, 2021
Merged
kobylynskyi pushed a commit that referenced this pull request Sep 5, 2021
@jxnu-liguobin @kobylynskyi
Scala: fix generateModelOpenClasses (#741)
e158de9 
When use `generateModelOpenClasses`, add `val` before field declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kobylynskyi kobylynskyi kobylynskyi approved these changes

Assignees

@jxnu-liguobin jxnu-liguobin

Labels

bug Something isn't working scala Pull requests that update Scala code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Scala] Setting generateModelOpenClasses := true will lead to compile failure

2 participants

@jxnu-liguobin @kobylynskyi