Add directive support for types #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I guess it was lost.(if graphql spec support it). |
kobylynskyi
approved these changes
Apr 22, 2021
Owner
kobylynskyi
left a comment
kobylynskyi
left a comment
There was a problem hiding this comment.
@robbertnoordzij thanks for your changes. And yes, the empty list was passed unintentionally.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@TGNThump reported an issue with the support of directives on an object level. Apparently, an empty list is passed through. I am not sure if this is on purpose or by accident. If this is an accident, I happy to clean up the implementation.
Related to #660
Changes were made to: