Skip to content

Conversation

@gdhordain
Copy link
Contributor

@gdhordain gdhordain commented Apr 9, 2021

Linked to issue #626.

Current status:

  • generate annotation
  • generate java resolver
  • generate kotlin resolver
  • generate scala resolver
  • plug with gradle plugin
  • plug with maven plugin
  • plug with sbt plugin

@gdhordain gdhordain force-pushed the generate-jackson-type-id-resolver branch 2 times, most recently from e07b4db to 53fa568 Compare April 9, 2021 11:12
@gdhordain gdhordain force-pushed the generate-jackson-type-id-resolver branch from 53fa568 to 984259d Compare April 9, 2021 11:14
kobylynskyi
kobylynskyi previously approved these changes Apr 9, 2021
@kobylynskyi
Copy link
Owner

@jxnu-liguobin could you please contribute kotlin and scala + sbt-related changes?
Thanks!

@jxnu-liguobin
Copy link
Collaborator

jxnu-liguobin commented Apr 10, 2021

@kobylynskyi @gdhordain
Because both union and interface are required __typename, Also need generat jackson type id for interface.

Of course, the PR can choose to solve only union. But I think it's a similar problem. It's better to solve it together as much as possible.

@jxnu-liguobin
Copy link
Collaborator

jxnu-liguobin commented Apr 10, 2021

@jxnu-liguobin could you please contribute kotlin and scala + sbt-related changes?
Thanks!

Yes, But It will take some time.

Please take a look. I've finished all the work in https://github.com/MOOM-Planet/graphql-java-codegen/pull/1/files

In order to complete PR faster, the annotation on the interface has not been solved for the time being.

Of course, the PR can choose to solve only union. But I think it's a similar problem. It's better to solve it together as much as possible.

jxnu-liguobin and others added 7 commits April 10, 2021 11:51
support scala jackosn enum annotation
support scala jackosn enum annotation
…t-field-and-typeid-at-class

support scala jackson-typeid annotations
jxnu-liguobin
jxnu-liguobin previously approved these changes Apr 15, 2021
@jxnu-liguobin
Copy link
Collaborator

Looks Good. 👍

@kobylynskyi kobylynskyi added this to the 5.1.0 milestone Apr 16, 2021
Copy link
Owner

@kobylynskyi kobylynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdhordain Looks great. Thanks!

@kobylynskyi kobylynskyi merged commit e15ac84 into kobylynskyi:develop Apr 19, 2021
@kobylynskyi kobylynskyi mentioned this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants