-
-
Notifications
You must be signed in to change notification settings - Fork 114
Generate jackson type id resolver #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate jackson type id resolver #637
Conversation
e07b4db to
53fa568
Compare
53fa568 to
984259d
Compare
src/main/resources/templates/java-lang/javaClassGraphqlJacksonTypeIdResolver.ftl
Outdated
Show resolved
Hide resolved
|
@jxnu-liguobin could you please contribute kotlin and scala + sbt-related changes? |
|
@kobylynskyi @gdhordain Of course, the PR can choose to solve only union. But I think it's a similar problem. It's better to solve it together as much as possible. |
...test/resources/expected-classes/jackson-resolver-union/GraphqlJacksonTypeIdResolver.java.txt
Outdated
Show resolved
Hide resolved
Yes, But It will take some time. Please take a look. I've finished all the work in https://github.com/MOOM-Planet/graphql-java-codegen/pull/1/files In order to complete PR faster, the annotation on the interface has not been solved for the time being.
|
src/main/java/com/kobylynskyi/graphql/codegen/mapper/GraphQLTypeMapper.java
Outdated
Show resolved
Hide resolved
support scala jackosn enum annotation
support scala jackosn enum annotation
…t-field-and-typeid-at-class support scala jackson-typeid annotations
src/main/java/com/kobylynskyi/graphql/codegen/java/JavaGraphQLTypeMapper.java
Outdated
Show resolved
Hide resolved
|
Looks Good. 👍 |
src/main/java/com/kobylynskyi/graphql/codegen/mapper/GraphQLTypeMapper.java
Show resolved
Hide resolved
kobylynskyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gdhordain Looks great. Thanks!
Linked to issue #626.
Current status: