Skip to content

Conversation

@kobylynskyi
Copy link
Owner

Closes #589

@kobylynskyi kobylynskyi added the do-not-merge PRs marked with this label are not ready to be merged label Mar 25, 2021
@kobylynskyi kobylynskyi added this to the 5.0.0 milestone Mar 25, 2021
@kobylynskyi kobylynskyi self-assigned this Mar 25, 2021
@kobylynskyi kobylynskyi changed the title Bump graphql-java to 16.2 #589 Bump graphql-java to 16.2, do not include external dependencies #564 #589 Mar 26, 2021
@kobylynskyi kobylynskyi removed the do-not-merge PRs marked with this label are not ready to be merged label Mar 26, 2021
@kobylynskyi
Copy link
Owner Author

@jxnu-liguobin could you please take a look at the failed sbt-test step? Thank you.

@jxnu-liguobin
Copy link
Collaborator

@kobylynskyi I can't find the problem. I'll pull it down and have a look

@jxnu-liguobin
Copy link
Collaborator

The problem was found. That example has used graphql-java, but did not import the dependency. (there is no such dependency in codgen).

add it here(example-client)
image

@kobylynskyi
Copy link
Owner Author

Thanks @jxnu-liguobin

@kobylynskyi kobylynskyi merged commit 6bf73f1 into develop Mar 28, 2021
@kobylynskyi kobylynskyi deleted the 589-graphql-java-16.2 branch March 28, 2021 01:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

85.1% 85.1% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants