Add ability to generate particular types as Java interfaces #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kobylynskyi please check, only one task is failed is sonar task: https://github.com/kobylynskyi/graphql-java-codegen/runs/2186852139 But it looks like it's CI configuration issue, not something related to my changes in this PR. |
Owner
|
Yes, Sonar fails for all PRs from forked repos. 🥴 |
kobylynskyi
requested changes
Mar 25, 2021
Owner
kobylynskyi
left a comment
kobylynskyi
left a comment
There was a problem hiding this comment.
@donbeave good job! Just one minor comment related to the codegen-options.md.
Once it is done - I am going to merge this to develop branch and release as part of 4.1.6.
Thanks again for the contribution! Much appreciate it.
kobylynskyi
approved these changes
Mar 25, 2021
kobylynskyi
added a commit
that referenced
this pull request
Mar 26, 2021
kobylynskyi
pushed a commit
that referenced
this pull request
Mar 26, 2021
* Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. (cherry picked from commit 994f6fe)
Merged
kobylynskyi
added a commit
that referenced
this pull request
Apr 1, 2021
…le/graphql-java-codegen-gradle-plugin (#616) * Add ability to generate particular types as Java interfaces #606 (#610) * Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. * Revert "Add ability to generate particular types as Java interfaces #606 (#610)" (#613) This reverts commit 994f6fe. * Bump com.gradle.plugin-publish Bumps com.gradle.plugin-publish from 0.13.0 to 0.14.0. Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexey Zhokhov <[email protected]> Co-authored-by: Bogdan Kobylynskyi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kobylynskyi
added a commit
that referenced
this pull request
Apr 5, 2021
…617) * Add ability to generate particular types as Java interfaces #606 (#610) * Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. * Revert "Add ability to generate particular types as Java interfaces #606 (#610)" (#613) This reverts commit 994f6fe. * Bump lombok from 1.18.18 to 1.18.20 in /plugins/maven/example-client Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.18 to 1.18.20. - [Release notes](https://github.com/rzwitserloot/lombok/releases) - [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.18...v1.18.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexey Zhokhov <[email protected]> Co-authored-by: Bogdan Kobylynskyi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kobylynskyi
added a commit
that referenced
this pull request
Apr 5, 2021
…#620) * Add ability to generate particular types as Java interfaces #606 (#610) * Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. * Revert "Add ability to generate particular types as Java interfaces #606 (#610)" (#613) This reverts commit 994f6fe. * Bump lombok from 1.18.18 to 1.18.20 in /plugins/gradle/example-client Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.18 to 1.18.20. - [Release notes](https://github.com/rzwitserloot/lombok/releases) - [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.18...v1.18.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexey Zhokhov <[email protected]> Co-authored-by: Bogdan Kobylynskyi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kobylynskyi
added a commit
that referenced
this pull request
Apr 5, 2021
…#619) * Add ability to generate particular types as Java interfaces #606 (#610) * Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. * Revert "Add ability to generate particular types as Java interfaces #606 (#610)" (#613) This reverts commit 994f6fe. * Bump lombok from 1.18.18 to 1.18.20 in /plugins/gradle/example-server Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.18 to 1.18.20. - [Release notes](https://github.com/rzwitserloot/lombok/releases) - [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.18...v1.18.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexey Zhokhov <[email protected]> Co-authored-by: Bogdan Kobylynskyi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kobylynskyi
added a commit
that referenced
this pull request
Apr 5, 2021
…618) * Add ability to generate particular types as Java interfaces #606 (#610) * Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. * Revert "Add ability to generate particular types as Java interfaces #606 (#610)" (#613) This reverts commit 994f6fe. * Bump lombok from 1.18.18 to 1.18.20 in /plugins/maven/example-server Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.18 to 1.18.20. - [Release notes](https://github.com/rzwitserloot/lombok/releases) - [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.18...v1.18.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexey Zhokhov <[email protected]> Co-authored-by: Bogdan Kobylynskyi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kobylynskyi
added a commit
that referenced
this pull request
Apr 6, 2021
…625) * Add ability to generate particular types as Java interfaces #606 (#610) * Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. * Revert "Add ability to generate particular types as Java interfaces #606 (#610)" (#613) This reverts commit 994f6fe. * Bump lombok from 1.18.18 to 1.18.20 in /plugins/maven/example-server Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.18 to 1.18.20. - [Release notes](https://github.com/rzwitserloot/lombok/releases) - [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.18...v1.18.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexey Zhokhov <[email protected]> Co-authored-by: Bogdan Kobylynskyi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kobylynskyi
added a commit
that referenced
this pull request
Apr 6, 2021
…#624) * Add ability to generate particular types as Java interfaces #606 (#610) * Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. * Revert "Add ability to generate particular types as Java interfaces #606 (#610)" (#613) This reverts commit 994f6fe. * Bump lombok from 1.18.18 to 1.18.20 in /plugins/gradle/example-client Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.18 to 1.18.20. - [Release notes](https://github.com/rzwitserloot/lombok/releases) - [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.18...v1.18.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexey Zhokhov <[email protected]> Co-authored-by: Bogdan Kobylynskyi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kobylynskyi
pushed a commit
that referenced
this pull request
Apr 6, 2021
* Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. (cherry picked from commit 994f6fe)
kobylynskyi
added a commit
that referenced
this pull request
Apr 6, 2021
…le/graphql-java-codegen-gradle-plugin (#616) * Add ability to generate particular types as Java interfaces #606 (#610) * Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. * Revert "Add ability to generate particular types as Java interfaces #606 (#610)" (#613) This reverts commit 994f6fe. * Bump com.gradle.plugin-publish Bumps com.gradle.plugin-publish from 0.13.0 to 0.14.0. Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexey Zhokhov <[email protected]> Co-authored-by: Bogdan Kobylynskyi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kobylynskyi
added a commit
that referenced
this pull request
Apr 6, 2021
…617) * Add ability to generate particular types as Java interfaces #606 (#610) * Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. * Revert "Add ability to generate particular types as Java interfaces #606 (#610)" (#613) This reverts commit 994f6fe. * Bump lombok from 1.18.18 to 1.18.20 in /plugins/maven/example-client Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.18 to 1.18.20. - [Release notes](https://github.com/rzwitserloot/lombok/releases) - [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.18...v1.18.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexey Zhokhov <[email protected]> Co-authored-by: Bogdan Kobylynskyi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kobylynskyi
added a commit
that referenced
this pull request
Apr 6, 2021
…#620) * Add ability to generate particular types as Java interfaces #606 (#610) * Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. * Revert "Add ability to generate particular types as Java interfaces #606 (#610)" (#613) This reverts commit 994f6fe. * Bump lombok from 1.18.18 to 1.18.20 in /plugins/gradle/example-client Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.18 to 1.18.20. - [Release notes](https://github.com/rzwitserloot/lombok/releases) - [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.18...v1.18.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexey Zhokhov <[email protected]> Co-authored-by: Bogdan Kobylynskyi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kobylynskyi
added a commit
that referenced
this pull request
Apr 6, 2021
…#619) * Add ability to generate particular types as Java interfaces #606 (#610) * Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. * Revert "Add ability to generate particular types as Java interfaces #606 (#610)" (#613) This reverts commit 994f6fe. * Bump lombok from 1.18.18 to 1.18.20 in /plugins/gradle/example-server Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.18 to 1.18.20. - [Release notes](https://github.com/rzwitserloot/lombok/releases) - [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.18...v1.18.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexey Zhokhov <[email protected]> Co-authored-by: Bogdan Kobylynskyi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kobylynskyi
added a commit
that referenced
this pull request
Apr 6, 2021
…618) * Add ability to generate particular types as Java interfaces #606 (#610) * Gradle 6.8.3. * Added typesAsInterfaces config option. * Updated doc. * Basic implementation for generating type as interface. * Tests for generating type as interface. * Code style fixes. * Code style fixes. * Java 1.8 build fixes. * Code style fixes. * Code style fixes. * Attempt to fix compilation. * Code review fixes. * Revert "Add ability to generate particular types as Java interfaces #606 (#610)" (#613) This reverts commit 994f6fe. * Bump lombok from 1.18.18 to 1.18.20 in /plugins/maven/example-server Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.18 to 1.18.20. - [Release notes](https://github.com/rzwitserloot/lombok/releases) - [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.18...v1.18.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexey Zhokhov <[email protected]> Co-authored-by: Bogdan Kobylynskyi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for this issue: #606