support generate normal public class for kotlin and scala. #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerate data class/case class. Now, not support Java record class.
|
I quickly scan through the change set for Kotlin and notice that you also generate LGTM for the kotlin change for #524 |
kobylynskyi
requested changes
Feb 20, 2021
src/main/resources/templates/kotlin-lang/kotlinClassGraphqlType.ftl
Outdated
Show resolved
Hide resolved
kobylynskyi
approved these changes
Feb 20, 2021
Owner
kobylynskyi
left a comment
kobylynskyi
left a comment
There was a problem hiding this comment.
@jxnu-liguobin you are fast 🚀
Merging it now.
Collaborator
Author
😸 We are in the daytime now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#524.
#548
1.Support generate normal public class for kotlin and scala. (Not support java 14 record.)
2.Fix response generation, return type not generated correctly (missing
?in kotlin).