Flag to specify whether the @Generated annotation is added #534
Conversation
|
sbt must use mappingConfig to set for every project, like this |
kobylynskyi
left a comment
kobylynskyi
left a comment
There was a problem hiding this comment.
@streibeb, thanks for the contribution. I think this change may be useful.
In addition to all the comments I made in individual files, could you please add some unit tests?
Thank you!
| generateClient := MappingConfigConstants.DEFAULT_GENERATE_CLIENT, | ||
| generateParameterizedFieldsResolvers := MappingConfigConstants.DEFAULT_GENERATE_PARAMETERIZED_FIELDS_RESOLVERS, | ||
| generateExtensionFieldsResolvers := MappingConfigConstants.DEFAULT_GENERATE_EXTENSION_FIELDS_RESOLVERS, | ||
| addGeneratedAnnotation := MappingConfigConstants.DEFAULT_ADD_GENERATED_ANNOTATION, |
| } | ||
| } | ||
| } | ||
| protected final MappingConfig mappingConfig; |
There was a problem hiding this comment.
In this repository, we use spaces instead of tabs, sorry 😄
Could you please change only the required lines and use spaces?
Thanks
| private List<ParameterDefinition> getFields(List<ExtendedFieldDefinition> fieldDefinitions, ExtendedDefinition<?, ?> parentDefinition) { | ||
| return this.dataModelMapperFactory.getFieldDefinitionToParameterMapper().mapFields(this, fieldDefinitions, parentDefinition); | ||
| } | ||
| private final MappingConfig config; |
There was a problem hiding this comment.
It's hard to tell which changes were made to the class. Could you please use spaces instead of tabs? Thanks.
| </#list> | ||
| */ | ||
| </#if> | ||
| <#if generatedAnnotation> |
There was a problem hiding this comment.
You can merge two statements:
<#if generatedAnnotation && generatedInfo.getGeneratedType()?has_content>This refers to all .ftl files.
There was a problem hiding this comment.
I was looking for the and operator and couldn't find anything about it! Will fix!
kobylynskyi
left a comment
kobylynskyi
left a comment
There was a problem hiding this comment.
@streibeb, looks good. Thanks for the contribution. I will update codegen-options.md
| generateClient := MappingConfigConstants.DEFAULT_GENERATE_CLIENT, | ||
| generateParameterizedFieldsResolvers := MappingConfigConstants.DEFAULT_GENERATE_PARAMETERIZED_FIELDS_RESOLVERS, | ||
| generateExtensionFieldsResolvers := MappingConfigConstants.DEFAULT_GENERATE_EXTENSION_FIELDS_RESOLVERS, | ||
| addGeneratedAnnotation := MappingConfigConstants.DEFAULT_ADD_GENERATED_ANNOTATION, |
There was a problem hiding this comment.
Please use mappingConfig to assign values to each project scope, Otherwise, the configuration is invalid
There was a problem hiding this comment.
@jxnu-liguobin could you please make the change? I already merged the PR to master branch. Thank you!
There was a problem hiding this comment.
@kobylynskyi The merged code no problem, has been modified
3 participants
Toggle the inclusion of the @generated annotation