Refactor scala tostring #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used by large number of fields). 2. For Scala(after that, kotlin will do the same), the `builder` is no longer generated by default.
kobylynskyi
approved these changes
Dec 3, 2020
Owner
kobylynskyi
left a comment
kobylynskyi
left a comment
There was a problem hiding this comment.
@jxnu-liguobin, looks good! Will release in 4.0.1 this week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is as follows
toStringandequalsmethods(Simplify code bloat caused by large number of fields, decrease by 50%).builderis no longer generated by default.generatebuilder:=false, the companion object was not generated.serializeUsingObjectMapperifinscalaClassGraphqlInterface.ftlandscalaClassGraphqlEnum.ftlPlease check to see if
toStringkeeps its original function(ParametrizedInput and Type). such assrc/test/resources/expected-classes/scala/tostring/QueryPrivateParametrizedInput.scala.txt
src/test/resources/expected-classes/scala/Commit.scala.txt