Skip to content

Gather library and maven/gradle plugins in a single repo #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 3, 2020
Merged

Gather library and maven/gradle plugins in a single repo #34

merged 16 commits into from
Apr 3, 2020

Conversation

@kobylynskyi
Copy link
Owner

@kobylynskyi kobylynskyi commented Apr 1, 2020

Closes #33

@kobylynskyi kobylynskyi added the enhancement New feature or request label Apr 1, 2020
@kobylynskyi kobylynskyi requested a review from joffrey-bion April 1, 2020 13:40
@kobylynskyi kobylynskyi self-assigned this Apr 1, 2020
@codecov
Copy link

codecov bot commented Apr 1, 2020 •
edited
Loading

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #34   +/-   ##
=========================================
  Coverage     88.85%   88.85%           
  Complexity      262      262           
=========================================
  Files            32       32           
  Lines           610      610           
  Branches         83       83           
=========================================
  Hits            542      542           
  Misses           45       45           
  Partials         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af4149...05e6ad4. Read the comment docs.

@kobylynskyi kobylynskyi changed the title Single repo plugins Gather library and maven/gradle plugins in a single repo Apr 1, 2020
@kobylynskyi
Copy link
Owner Author

kobylynskyi commented Apr 1, 2020

@joffrey-bion could you please take a look at this?

@kobylynskyi kobylynskyi linked an issue Apr 2, 2020 that may be closed by this pull request
Add Contributing Guidelines #35
Closed
This was referenced Apr 2, 2020
Closed
Closed
joffrey-bion
joffrey-bion reviewed Apr 3, 2020
View reviewed changes
joffrey-bion
joffrey-bion reviewed Apr 3, 2020
View reviewed changes
@kobylynskyi kobylynskyi requested a review from joffrey-bion April 3, 2020 12:55
@joffrey-bion
Copy link
Contributor

joffrey-bion commented Apr 3, 2020

Thanks for all the work you put in this!

@kobylynskyi kobylynskyi merged commit ab7fc44 into master Apr 3, 2020
@kobylynskyi kobylynskyi deleted the single-repo-plugins branch April 3, 2020 16:26
@kobylynskyi kobylynskyi added this to the 1.5.0 milestone Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joffrey-bion joffrey-bion joffrey-bion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kobylynskyi kobylynskyi

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

Add Contributing Guidelines Gather plugins and core library in same repo?

3 participants

@kobylynskyi @joffrey-bion