Skip to content

DataFetchResult generaton #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Feb 24, 2024
Merged

DataFetchResult generaton #1431

merged 20 commits into from
Feb 24, 2024

Conversation

@kirill071992
Copy link
Contributor

@kirill071992 kirill071992 commented Dec 12, 2023

Description

Related to #1416

Changes were made to:

  • Codegen library - Java
  • Gradle plugin

@kirill071992 kirill071992 changed the title Data fetch result generaton DataFetchResult generaton Dec 12, 2023
@kirill071992 kirill071992 marked this pull request as ready for review December 15, 2023 17:31
@kobylynskyi
Copy link
Owner

kobylynskyi commented Dec 15, 2023 •
edited
Loading

@kirill071992 I have a question about the overall approach. What if user wants to specify a lsit of types or specific fields that should be generated with DataFetcherResult<>? Currently you support it only through directives, which is not flexible. All other config options do support other options besides @directive, which are: Type, or Type.field. Please follow similar logic. Thanks

kobylynskyi
kobylynskyi requested changes Dec 15, 2023
View reviewed changes
@kirill071992
Copy link
Contributor Author

kirill071992 commented Jan 10, 2024

@kirill071992 I have a question about the overall approach. What if user wants to specify a lsit of types or specific fields that should be generated with DataFetcherResult<>? Currently you support it only through directives, which is not flexible. All other config options do support other options besides @directive, which are: Type, or Type.field. Please follow similar logic. Thanks

Done

@kirill071992
Copy link
Contributor Author

kirill071992 commented Jan 15, 2024

@kobylynskyi could you please look at it again

@kirill071992
Copy link
Contributor Author

kirill071992 commented Feb 1, 2024

@kobylynskyi :)

kobylynskyi
kobylynskyi requested changes Feb 1, 2024
View reviewed changes
Copy link
Owner

@kobylynskyi kobylynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirill071992 looks great! One minor comment and we should be good to go. Thanks!

@kobylynskyi kobylynskyi added this to the 5.10.0 milestone Feb 1, 2024
kobylynskyi
kobylynskyi previously approved these changes Feb 2, 2024
View reviewed changes
Copy link
Owner

@kobylynskyi kobylynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirill071992 looks good! Will merge soon and include in the next release.
Thanks for the contribution!

@kobylynskyi
Merge remote-tracking branch 'upstream/main' into data-fetch-result-g…
82ace9e 
…eneraton

# Conflicts:
#	docs/codegen-options.md
#	src/main/java/com/kobylynskyi/graphql/codegen/java/JavaGraphQLTypeMapper.java
@kobylynskyi
Fix codegen-options.md formatting
32ea7a4
@kobylynskyi kobylynskyi merged commit bba3088 into kobylynskyi:main Feb 24, 2024
@kobylynskyi kobylynskyi added the enhancement New feature or request label Feb 24, 2024
@kobylynskyi
Copy link
Owner

kobylynskyi commented Feb 24, 2024

This was released in 5.10.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kobylynskyi kobylynskyi kobylynskyi approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

5.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kirill071992 @kobylynskyi