support placeholder at apiReturnListType and apiReturnType #1200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobylynskyi
requested changes
May 11, 2023
Owner
kobylynskyi
left a comment
kobylynskyi
left a comment
There was a problem hiding this comment.
@matsudamper the approach looks good to me. Can you please fix a minor comment I have in Java/Kotlin/Scala mappers and we should be good to merge this. Thanks
| return computedTypeName.replace(JAVA_UTIL_LIST, mappingContext.getApiReturnListType()); | ||
| if (mappingContext.getApiReturnListType().contains(MappingConfigConstants.API_RETURN_NAME_PLACEHOLDER)) { | ||
| Matcher matcher = JAVA_UTIL_LIST_ELEMENT_REGEX.matcher(computedTypeName); | ||
| matcher.find(); |
Owner
There was a problem hiding this comment.
@matsudamper I think it's better if you do if (matcher.find()) { ... }
| boolean isNullable = computedTypeName.endsWith(KOTLIN_UTIL_NULLABLE); | ||
|
|
||
| Matcher matcher = KOTLIN_UTIL_LIST_ELEMENT_REGEX.matcher(computedTypeName); | ||
| matcher.find(); |
Owner
There was a problem hiding this comment.
@matsudamper I think it's better if you do if (matcher.find()) { ... }
| return computedTypeName.replace(SCALA_UTIL_LIST, mappingContext.getApiReturnListType()); | ||
| if (mappingContext.getApiReturnListType().contains(MappingConfigConstants.API_RETURN_NAME_PLACEHOLDER)) { | ||
| Matcher matcher = SCALA_UTIL_LIST_ELEMENT_REGEX.matcher(computedTypeName); | ||
| matcher.find(); |
Owner
There was a problem hiding this comment.
@matsudamper I think it's better if you do if (matcher.find()) { ... }
kobylynskyi
approved these changes
May 15, 2023
Owner
kobylynskyi
left a comment
kobylynskyi
left a comment
There was a problem hiding this comment.
LGTM! Will include this feature in the next release. Thank you for the contribution!
matsudamper
deleted the
feature/damper/api-return-type-and-list-placeholder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #1167
Added placeholder support for apiReturnListType and apiReturnType.
The following syntax is supported.
Changes were made to: