Skip to content

Conversation

@velo
Copy link
Contributor

@velo velo commented Mar 20, 2023


Description

Related to #1048

Only realized I was testing the wrong SNAPSHOT when I change the version from 5.6.1-SNAPSHOT to 5.7.0-SNAPSHOT.

Can't use the enum as key on the map, as build tools will inject strings.

Also did a minor improvement that allow to setup maven like this:

<configuration>
  <customTemplates>
    <TYPE>src/main/resource/type.ftl</TYPE>
  </customTemplates>
<configuration>

Before template need to be on classpath and was whole lot more complicated


Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala
  • Maven plugin
  • Gradle plugin
  • SBT plugin

@kobylynskyi
Copy link
Owner

kobylynskyi commented Mar 20, 2023

@velo changes look good. Can you please fix the build? (checkstyle issues)

@velo
Copy link
Contributor Author

velo commented Mar 20, 2023

@velo changes look good. Can you please fix the build? (checkstyle issues)

BTW, can I run checkstyle locally?

I enabled the plugin, but seems I don't get the same warnings...

@kobylynskyi kobylynskyi merged commit e8f7cd6 into kobylynskyi:develop Mar 22, 2023
@kobylynskyi
Copy link
Owner

@velo yes, you can. There are plugins for different IDEs and you can import the rules from the following folder: config/check-style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants