-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[release-1.0] Reduce the period and failure threshold for activator readiness #12620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.0] Reduce the period and failure threshold for activator readiness #12620
Conversation
The default drain timeout is 45 seconds which was much shorter than the time it takes the activator to be recognized as not ready (2 minutes) This was resulting in 503s since the activator was receiving traffic when it was not expecting it
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #12620 +/- ##
==============================================
Coverage ? 87.44%
==============================================
Files ? 196
Lines ? 9628
Branches ? 0
==============================================
Hits ? 8419
Misses ? 931
Partials ? 278 Continue to review full report at Codecov.
|
|
/override pull-knative-serving-upgrade-tests |
|
@dprotaso: Overrode contexts on behalf of dprotaso: pull-knative-serving-upgrade-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override pull-knative-serving-istio-latest-no-mesh |
|
@dprotaso: Overrode contexts on behalf of dprotaso: pull-knative-serving-istio-latest-no-mesh In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #12614