Skip to content

Reduce the period and failure threshold for activator readiness #12614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Reduce the period and failure threshold for activator readiness #12614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion config/core/deployments/activator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,15 @@ spec:
httpHeaders:
- name: k-kubelet-probe
value: "activator"
failureThreshold: 12
periodSeconds: 5
failureThreshold: 1
livenessProbe:
httpGet:
port: 8012
httpHeaders:
- name: k-kubelet-probe
value: "activator"
periodSeconds: 10
Copy link
Member

@psschwei psschwei Feb 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why the need for the livenessProbe update? (edlt: Don't think it's super important, 10s is the default value, so don't believe this is changing its behavior)

Copy link
Member Author

@dprotaso dprotaso Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is 10 so I just made it explicit.

Cause when I saw the failureThreshold of 12 it wasn't obvious (without looking it up) that it would take 120s

failureThreshold: 12
initialDelaySeconds: 15

Expand Down