-
Notifications
You must be signed in to change notification settings - Fork 350
keep allocations as small as possible #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -181,11 +181,13 @@ func (s *sequenceDecs) decode(seqs int, br *bitReader, hist []byte) error { | |||||||||||||||||
| return fmt.Errorf("output (%d) bigger than max block size", size) | ||||||||||||||||||
| } | ||||||||||||||||||
| if size > cap(s.out) { | ||||||||||||||||||
| // Not enough size, will be extremely rarely triggered, | ||||||||||||||||||
| // Not enough size, which can happen under high volume block streaming conditions | ||||||||||||||||||
| // but could be if destination slice is too small for sync operations. | ||||||||||||||||||
| // We add maxBlockSize to the capacity. | ||||||||||||||||||
| s.out = append(s.out, make([]byte, maxBlockSize)...) | ||||||||||||||||||
| s.out = s.out[:len(s.out)-maxBlockSize] | ||||||||||||||||||
| // over-allocating here can create a large amount of GC pressure so we try to keep | ||||||||||||||||||
| // it as contained as possible | ||||||||||||||||||
| addBytes := 1024 + (size - len(s.out)) | ||||||||||||||||||
|
||||||||||||||||||
| addBytes := 1024 + (size - len(s.out)) | |
| used := len(s.out) - startSize | |
| addBytes := 256 + ll + ml + used>>2 | |
| // Clamp to max block size. | |
| if used+addBytes > maxBlockSize { | |
| addBytes = maxBlockSize - used | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok gave that change a whirl
there's about a 500-750Mb difference in the ram usage, higher using method, then the original size - len one, but it does seem to not get out of control, which is the desired effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. I will merge when Ci tests are done and probably release it tomorrow.
Uh oh!
There was an error while loading. Please reload this page.