Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

Conversation

@khoih-prog
Copy link
Owner

This PR is from @salasidis


As per the Readme.md file - I am getting 66k instead of 374k max heap space in my application. I should have no problem sending 2M files, or web pages larger than the main RAM

Since I create the web page once, and reuse, I make a second copy of the web page, so that when the send happens (which messes wit the actual string), I simply recopy C string C string for the next send - fast, easy, and almost no code changes required (none if you don't wish to use the features 0 fully backwards compatible I think)

request->send(200, "text/html", html_out, false);
strcpy(html_out, html_out_bak);

@khoih-prog
Copy link
Owner Author

LGTM. You've written very good code.

Can you make some minor changes to match with the current styles

  1. Using AWS_LOGDEBUGx instead of Serial.printxx
  2. Using tab = 2 spaces for correct indentation
  3. Modify in README.md correctly by adding a note how to use the new feature / function

BTW, to create a PR, after you've forked the library and have done all the mods, just press Pull Requests (upper left corner, next to Code, and proceed. Just so simple for you.

@khoih-prog khoih-prog closed this Oct 2, 2022
@khoih-prog khoih-prog added the enhancement New feature or request label Oct 2, 2022
Repository owner locked and limited conversation to collaborators Oct 2, 2022
@khoih-prog
Copy link
Owner Author

Replaced by the real PR #8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request->send(200, textPlainStr, jsonChartDataCharStr); - Without using String Class - to save heap

2 participants