Skip to content

bpf: refactor max_depth computation in bpf_get_stack() #9732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: bpf-next_base
Choose a base branch
from
Open

bpf: refactor max_depth computation in bpf_get_stack() #9732

wants to merge 3 commits into from
+48 −20

Conversation

kernel-patches-daemon-bpf[bot]
Copy link

Pull request for series with
subject: bpf: refactor max_depth computation in bpf_get_stack()
version: 9
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: a578b54
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977
version: 9

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: fd2e081
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977
version: 9

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 32d3766
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977
version: 9

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: f7528e4
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977
version: 9

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 61ee2cc
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977
version: 9

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 3ae4c52
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977
version: 9

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: b13448d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977
version: 9

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 180a46b
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977
version: 9

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: a24a2dd
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977
version: 9

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 6ff4a0f
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977
version: 9

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 3547a61
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977
version: 9

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 8cd189e
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977
version: 9

@ArnaudLcm
bpf: refactor max_depth computation in bpf_get_stack()
b3a7ed0 
A new helper function stack_map_calculate_max_depth() that
computes the max depth for a stackmap.

Acked-by: Yonghong Song <[email protected]>
Acked-by: Song Liu <[email protected]>
Signed-off-by: Arnaud Lecomte <[email protected]>
@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 815276d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1001977
version: 9

@ArnaudLcm
bpf: clean-up bounds checking in __bpf_get_stack
9f2a53d 
Clean-up bounds checking for trace->nr in
__bpf_get_stack by limiting it only to
max_depth.

Acked-by: Song Liu <[email protected]>
Cc: Song Liu <[email protected]>
Signed-off-by: Arnaud Lecomte <[email protected]>
@ArnaudLcm
bpf: fix stackmap overflow check in __bpf_get_stackid()
120ddc8 
Syzkaller reported a KASAN slab-out-of-bounds write in __bpf_get_stackid()
when copying stack trace data. The issue occurs when the perf trace
 contains more stack entries than the stack map bucket can hold,
 leading to an out-of-bounds write in the bucket's data array.

Reported-by: [email protected]
Closes: https://syzkaller.appspot.com/bug?extid=c9b724fbb41cf2538b7b
Fixes: ee2a098 ("bpf: Adjust BPF stack helper functions to accommodate skip > 0")
Acked-by: Yonghong Song <[email protected]>
Acked-by: Song Liu <[email protected]>
Signed-off-by: Arnaud Lecomte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bpf-next new V9-ci-fail V9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ArnaudLcm