Skip to content

Conversation

@sazo
Copy link
Contributor

@sazo sazo commented Dec 20, 2017

What: fix #148

Why: cross-env-shell does not work for macOS

How: The best possible way by @brucejo75

ALL credit goes to @brucejo75 i just making the PR because cross-env-shell does not work cross platform :)

@codecov
Copy link

codecov bot commented Dec 20, 2017

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #158   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          57     63    +6     
  Branches       13     14    +1     
=====================================
+ Hits           57     63    +6
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50299d9...c73deb5. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks both of you!

@kentcdodds kentcdodds merged commit 7fa5c08 into kentcdodds:master Dec 21, 2017
This was referenced Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cross-env, cross-env-shell not working on MacOS.13

3 participants