feat(rename): rename the project to babel-plugin-macros #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
force-pushed
the
pr/rename2
branch
from
0d8996f to
053beb8
Compare
kentcdodds
commented
Dec 9, 2017
| "eslintIgnore": ["node_modules", "coverage", "dist"], | ||
| "babel": { | ||
| "presets": ["./.babelrc.js"] | ||
| "presets": ["./other/babel-config.js"] |
Owner
Author
There was a problem hiding this comment.
Had to do things this way so that kcd-scripts and v7 of babel works :)
Closes #41 BREAKING CHANGE: upgrades to babel v7 and renames to babel-plugin-macros
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 73 73
Branches 18 18
=====================================
Hits 73 73
Continue to review full report at Codecov.
|
kentcdodds
force-pushed
the
pr/rename2
branch
from
053beb8 to
4b2b65d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: This renames everything and upgrades to babel v7
Why: Closes #41
How: Find/replace for both files and text within files. Then upgrade babel stuff.
Miraculously it all still works even though kcd-scripts uses babel 6 😄