Skip to content

Conversation

@wozniakjan
Copy link
Member

@wozniakjan wozniakjan commented Oct 14, 2025

Fixing two common issues that happen on all PRs

1) mismatch between expected go version and required go version

number of PRs fail CI checks due to 1.24 version of go being configured in the github workflows which ends up selecting 1.24.3 but go.mod requires 1.24.7.

Run make e2e-test
  make e2e-test
  shell: /usr/bin/bash -e {0}
  env:
    KUBECONFIG: /root/runner/keda-arm64-http-add-on-2/_work/http-add-on/http-add-on/.kube/config
    GOTOOLCHAIN: local
    VERSION: 8208b0494ecd327507c06c13811c3033a9ebe05e
go run -tags e2e ./tests/run-all.go
go: go.mod requires go >= 1.24.7 (running go 1.24.3; GOTOOLCHAIN=local)

make: *** [Makefile:92: e2e-test] Error 1

2) linkinator 429 error

for some reason, linkinator still struggles with getting rate-limited by github. Replacing linkinator with lychee which is capable of handling retries for 429 errors much better.

Error: Detected 1 broken links.
 docs/install.md
   [429] https://github.com/kedacore/charts/blob/master/http-add-on/values.yaml

e.g. https://github.com/kedacore/http-add-on/actions/runs/18491652982/job/52700033142

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

see also: https://github.com/kedacore/http-add-on/actions/runs/18462756880/job/52685116762?pr=1354

Signed-off-by: Jan Wozniak <[email protected]>
@wozniakjan wozniakjan requested a review from Copilot October 14, 2025 09:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates Go version in GitHub workflow files to resolve CI failures caused by version mismatch between workflow configuration and go.mod requirements.

  • Updated Go version specification from "1.24" to "1.24.7" in CI workflows
  • Ensures consistency between workflow Go version and go.mod minimum requirement of 1.24.7

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/tests.yaml Updated Go version to 1.24.7 for tests workflow
.github/workflows/e2e-tests.yaml Updated Go version to 1.24.7 for both e2e test jobs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wozniakjan wozniakjan changed the title ci: bump go to 1.24.7 ci: bump go to 1.24.7 and fix link checker Oct 14, 2025
@wozniakjan wozniakjan changed the title ci: bump go to 1.24.7 and fix link checker [wip] ci: bump go to 1.24.7 and fix link checker Oct 14, 2025
@wozniakjan wozniakjan changed the title [wip] ci: bump go to 1.24.7 and fix link checker ci: bump go to 1.24.7 and fix link checker Oct 14, 2025
@wozniakjan wozniakjan requested a review from Copilot October 14, 2025 12:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wozniakjan wozniakjan merged commit 70a640a into kedacore:main Oct 14, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant