Skip to content

Conversation

@zroubalik
Copy link
Member

No description provided.

@zroubalik zroubalik marked this pull request as ready for review October 8, 2025 13:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependencies to Kubernetes 0.33.5 and KEDA core 2.18.0, bringing the project up to date with the latest versions of these critical dependencies.

  • Updates Kubernetes dependencies from v0.31.7 to v0.33.5
  • Updates KEDA core from v2.17.1 to v2.18.0
  • Updates various OpenTelemetry and other dependencies to their latest versions

Reviewed Changes

Copilot reviewed 11 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
go.mod Updates all core dependencies including k8s, KEDA, and OpenTelemetry packages
interceptor/metrics/prommetrics_test.go Updates test expectations to include new otel_scope_schema_url field
hack/*.sh Updates scripts to use new tooling patterns and binary paths
Makefile Refactors tool installation to use local bin directory pattern
.golangci.yml Adds vendor path exclusion and specific linter exemptions
.github/workflows/tests.yaml Updates workflow to use go mod vendor for module management
config/crd/bases/http.keda.sh_httpscaledobjects.yaml Updates controller-gen version annotation
README.md Fixes contributing guidelines link
hack/tools.go Adds new tool dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zroubalik
Copy link
Member Author

Seems like we need to fix otel e2e test as well:

2025-10-08T13:46:15.1318011Z tests/checks/interceptor_otel_tracing/interceptor_otel_tracing_test.go has failed after 3 tries 
2025-10-08T13:46:15.1318760Z try number 1
2025-10-08T13:46:15.1319096Z === RUN   TestTraceGeneration
2025-10-08T13:46:15.1319761Z     interceptor_otel_tracing_test.go:244: --- setting up ---
2025-10-08T13:46:15.1320651Z     helper.go:224: deleting namespace interceptor-otel-tracing-test-ns
2025-10-08T13:46:15.1321697Z     helper.go:278: waiting for namespace interceptor-otel-tracing-test-ns deletion
2025-10-08T13:46:15.1322341Z     helper.go:211: Creating namespace - interceptor-otel-tracing-test-ns
2025-10-08T13:46:15.1322913Z     helper.go:521: Applying template: zipkinTemplate
2025-10-08T13:46:15.1323451Z     helper.go:521: Applying template: deploymentTemplate
2025-10-08T13:46:15.1324141Z     helper.go:521: Applying template: serviceNameTemplate
2025-10-08T13:46:15.1324797Z     helper.go:521: Applying template: clientTemplate
2025-10-08T13:46:15.1325614Z     helper.go:521: Applying template: httpScaledObjectTemplate
2025-10-08T13:46:15.1326634Z     helper.go:382: Waiting for deployment replicas to hit target. Deployment - interceptor-otel-tracing-test-deployment, Current  - 0, Target - 0
2025-10-08T13:46:15.1327849Z     helper.go:382: Waiting for deployment replicas to hit target. Deployment - zipkin, Current  - 0, Target - 1
2025-10-08T13:46:15.1329245Z     helper.go:382: Waiting for deployment replicas to hit target. Deployment - zipkin, Current  - 1, Target - 1
2025-10-08T13:46:15.1330350Z     interceptor_otel_tracing_test.go:276: --- sending load ---
2025-10-08T13:46:15.1331075Z     helper.go:521: Applying template: loadJobTemplate
2025-10-08T13:46:15.1332323Z     helper.go:382: Waiting for deployment replicas to hit target. Deployment - interceptor-otel-tracing-test-deployment, Current  - 0, Target - 1
2025-10-08T13:46:15.1334400Z     helper.go:382: Waiting for deployment replicas to hit target. Deployment - interceptor-otel-tracing-test-deployment, Current  - 1, Target - 1
2025-10-08T13:46:15.1335811Z     interceptor_otel_tracing_test.go:266: 
2025-10-08T13:46:15.1337393Z         	Error Trace:	/home/runner/work/http-add-on/http-add-on/tests/checks/interceptor_otel_tracing/interceptor_otel_tracing_test.go:266
2025-10-08T13:46:15.1338409Z         	Error:      	"0" is not greater than or equal to "1"
2025-10-08T13:46:15.1338779Z         	Test:       	TestTraceGeneration
2025-10-08T13:46:15.1339098Z     interceptor_otel_tracing_test.go:269: 
2025-10-08T13:46:15.1340376Z         	Error Trace:	/home/runner/work/http-add-on/http-add-on/tests/checks/interceptor_otel_tracing/interceptor_otel_tracing_test.go:269
2025-10-08T13:46:15.1341188Z         	Error:      	Not equal: 
2025-10-08T13:46:15.1341680Z         	            	expected: "200"
2025-10-08T13:46:15.1342022Z         	            	actual  : ""
2025-10-08T13:46:15.1342338Z         	            	
2025-10-08T13:46:15.1342700Z         	            	Diff:
2025-10-08T13:46:15.1343043Z         	            	--- Expected
2025-10-08T13:46:15.1343504Z         	            	+++ Actual
2025-10-08T13:46:15.1343825Z         	            	@@ -1 +1 @@
2025-10-08T13:46:15.1344420Z         	            	-200
2025-10-08T13:46:15.1344676Z         	            	+
2025-10-08T13:46:15.1345051Z         	Test:       	TestTraceGeneration
2025-10-08T13:46:15.1345683Z     helper.go:569: Deleting template: httpScaledObjectTemplate
2025-10-08T13:46:15.1346241Z     helper.go:569: Deleting template: clientTemplate
2025-10-08T13:46:15.1346700Z     helper.go:569: Deleting template: serviceNameTemplate
2025-10-08T13:46:15.1347180Z     helper.go:569: Deleting template: deploymentTemplate
2025-10-08T13:46:15.1347681Z     helper.go:569: Deleting template: zipkinTemplate
2025-10-08T13:46:15.1348377Z     helper.go:224: deleting namespace interceptor-otel-tracing-test-ns
2025-10-08T13:46:15.1349140Z     helper.go:278: waiting for namespace interceptor-otel-tracing-test-ns deletion
2025-10-08T13:46:15.1350269Z     helper.go:278: waiting for namespace interceptor-otel-tracing-test-ns deletion
2025-10-08T13:46:15.1351389Z     helper.go:278: waiting for namespace interceptor-otel-tracing-test-ns deletion
2025-10-08T13:46:15.1352140Z --- FAIL: TestTraceGeneration (87.43s)
2025-10-08T13:46:15.1352580Z FAIL
2025-10-08T13:46:15.1352915Z FAIL	command-line-arguments	87.456s
2025-10-08T13:46:15.1353335Z FAIL
2025-10-08T13:46:15.1353501Z 
2025-10-08T13:46:15.1353629Z try number 2

@wozniakjan
Copy link
Member

Seems like we need to fix otel e2e test as well:

I think I found the culprit - #1358. Will rebase this PR if I manage to fix it.

Signed-off-by: Jan Wozniak <[email protected]>
@wozniakjan wozniakjan merged commit eadc02a into kedacore:main Oct 16, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants