Feature/optional files class #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orting libraries for all storage backends
soustruh
requested changes
Sep 16, 2025
Contributor
soustruh
left a comment
soustruh
left a comment
There was a problem hiding this comment.
I propose two tiny changes, please consider yourself whether you find them worth implementing or not…
kbcstorage/client.py
Outdated
| """ | ||
|
|
||
| def __init__(self, api_domain, token, branch_id='default'): | ||
| def __init__(self, api_domain, token, branch_id='default', without_files=False): |
Contributor
There was a problem hiding this comment.
Just one minor readability issue, it's generally recommended to name variables in a positive way, not with a negative meaning. Instead of
if not without_files
you'd end up for example with
if initialize_files_object
which is understandable at first sight without decoding double negation. 🙂
kbcstorage/client.py
Outdated
| "https://connection.keboola.com". | ||
| token (str): A storage API key. | ||
| branch_id (str): The ID of branch to use, use 'default' to work without branch (in main). | ||
| without_files (bool): If True saves memory by not importing files and libraries for all backends. |
soustruh
approved these changes
Sep 16, 2025
Contributor
soustruh
left a comment
soustruh
left a comment
There was a problem hiding this comment.
Thanks for the changes 😇
ujovlado
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.