Skip to content

Conversation

@olamilekan000
Copy link
Contributor

Summary

change adds original resource version and UID to object before storing in the cache server

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #
#3631

Release Notes

Adds resource version and UID to object's annotation before persisting to the cache server

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Oct 15, 2025
@kcp-ci-bot kcp-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2025
@olamilekan000 olamilekan000 requested a review from embik October 15, 2025 12:19
@olamilekan000
Copy link
Contributor Author

/retest

@olamilekan000 olamilekan000 force-pushed the persist-original-rv-in-cache-server branch 2 times, most recently from 3047616 to e0736fd Compare October 15, 2025 22:31
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2025
@olamilekan000 olamilekan000 force-pushed the persist-original-rv-in-cache-server branch from e0736fd to a00e687 Compare October 15, 2025 22:32
@olamilekan000
Copy link
Contributor Author

/retest

Copy link
Contributor

@mjudeikis mjudeikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6bf6c09dc7ec9be229fde0ebf5bf88183c973526

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2025
@kcp-ci-bot kcp-ci-bot merged commit 8265c39 into kcp-dev:main Oct 16, 2025
14 checks passed
@gman0 gman0 mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants