Skip to content

Conversation

@embik
Copy link
Member

@embik embik commented Oct 1, 2025

Summary

Follow-up PR to https://groups.google.com/g/kcp-dev/c/ZE12NB-MDPA/m/l9t-IDy1AQAJ, voting in the initial set of GitHub Admin Team members.

Since the list of team members has been confirmed with a maintainer vote, this PR doesn't require a maintainer council majority. Simple approve will suffice.

What Type of PR Is This?

/kind documentation

Related Issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 1, 2025
@mjudeikis
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d164b58c2cbff162417dfcf9cfef3962975c8e0a

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2025
@embik
Copy link
Member Author

embik commented Oct 1, 2025

/hold

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2025
@embik embik force-pushed the admin-team-members branch from 630c2eb to 6d59173 Compare October 1, 2025 07:33
@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@kcp-ci-bot kcp-ci-bot requested a review from mjudeikis October 1, 2025 07:33
@embik
Copy link
Member Author

embik commented Oct 1, 2025

Made a typo, sorry.

/hold cancel

@kcp-ci-bot kcp-ci-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2025
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Even though I would have alphabetically sorted the list.

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d3fbf4d0753e1328a9c6602526954e976c5e758

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot merged commit 0f97ee0 into kcp-dev:main Oct 1, 2025
9 checks passed
@embik embik deleted the admin-team-members branch October 1, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants