Skip to content

Introduce standalone SDK #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 16, 2025
Merged

Introduce standalone SDK #60

merged 9 commits into from
May 16, 2025

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented May 15, 2025

Summary

This is exactly what kcp is also doing, declaring the SDK to be a standalone module to make it easier to import. I updated the codegen logic to "the best" kcp on kube 1.31 has to offer. Once kcp 0.28 is out, we can switch to kube_codegen.sh and cluster_codegen.sh and make it all silky smooth.

What Type of PR Is This?

/kind feature

Release Notes

`github.com/kcp-dev/api-syncagent/sdk` is now a standalone Go module

@xrstf xrstf requested a review from embik May 15, 2025 15:01
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2025
@kcp-ci-bot kcp-ci-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2025
embik
embik requested changes May 16, 2025
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we maybe add a quick markdown doc somewhere for the release process so that people tagging this repo are aware they need to tag both sdk and main module?

embik
embik approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 63fe19c3155c710bab356f1208035a5fa6a8b929

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2025
@kcp-ci-bot kcp-ci-bot merged commit ddfd0f7 into main May 16, 2025
8 of 9 checks passed
@kcp-ci-bot kcp-ci-bot deleted the sdk-module branch May 16, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xrstf @kcp-ci-bot @embik