🐛 Handle long object names #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 02dda869bc51d195ae9de1c7ad8a5730678172c6
|
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Objects in Kubernetes can have names up to 253 characters in length. However label values must not be longer than 63 characters. Since the agent uses the remote (kcp) name/namespace as labels, the syncing failed when objects with names longer than 63 characters were in kcp.
This PR fixes that by hashing the namespace/name and storing the original names, for reference, as annotations instead. The same issue affected the secret store, because keys in a secret's data must also not be overly long, so the agent now uses hashes for these as well.
Existing synced objects will not be found under this new implementation, but the agent will already automatically "adopt" existing objects and re-label/annotate them as needed. The data in the store secrets will also be recreated, so effectively every object is fully re-created on the service cluster side, potentially undoing changes from operators. Good thing this is alpha software 😁
Related issue(s)
Fixes #34
Release Notes