Skip to content

Pass API server address to HelmController @jip149 #13023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −6
Open

Pass API server address to HelmController @jip149 #13023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c2aefb
Remember default API server bind address
jip149 Oct 3, 2025
d550b67
Pass API server address to HelmController
jip149 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/daemons/control/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,11 +237,7 @@ func apiServer(ctx context.Context, cfg *config.Control) error {
argsMap["advertise-address"] = cfg.AdvertiseIP
}
argsMap["secure-port"] = strconv.Itoa(cfg.APIServerPort)
if cfg.APIServerBindAddress == "" {
argsMap["bind-address"] = cfg.Loopback(false)
} else {
argsMap["bind-address"] = cfg.APIServerBindAddress
}
argsMap["bind-address"] = cfg.APIServerBindAddress
if cfg.EgressSelectorMode != config.EgressSelectorModeDisabled {
argsMap["enable-aggregator-routing"] = "true"
argsMap["egress-selector-config-file"] = runtime.EgressSelectorConfig
Expand Down Expand Up @@ -300,6 +296,10 @@ func defaults(config *config.Control) {
}
}

if config.APIServerBindAddress == "" {
config.APIServerBindAddress = config.Loopback(false)
}

if config.DataDir == "" {
config.DataDir = "./management-state"
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,8 @@ func coreControllers(ctx context.Context, sc *Context, config *Config) error {
metav1.NamespaceAll,
helmcommon.Name,
"cluster-admin",
strconv.Itoa(config.ControlConfig.HTTPSPort),
config.ControlConfig.APIServerBindAddress,
strconv.Itoa(config.ControlConfig.APIServerPort),
k8s,
apply,
util.BuildControllerEventRecorder(k8s, helmcommon.Name, metav1.NamespaceAll),
Expand Down