This repository was archived by the owner on Mar 23, 2024. It is now read-only.
Fix generating javascript tag using with Rails.application.config.relative_url_root set #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls.application.config.relative_url_root` set
bolshakov
force-pushed
the
feature/work-with-relative-url-path
branch
from
9679ab2 to
91a9635
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It generates right url for JS files loaded via
require.js, but it generates url without prefix forrequire.jsitself and main script.For example when
Rails.application.config.relative_url_rootset to/sub-pathand you callrequirejs_include_tag 'application'from a view, it tries to lead/assets/application.jsinstead of/sub-path/assets/application.js