Skip to content

Conversation

@GunnarFarneback
Copy link
Collaborator

According to JuliaLang/julia#59593 it's a bad idea to use Base.get_extension and this alternative arguably looks nicer anyway.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.31%. Comparing base (5ed108b) to head (f1a668d).
⚠️ Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
ext/CUDAExt.jl 0.00% 4 Missing ⚠️
src/highlevel.jl 0.00% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   88.37%   86.31%   -2.06%     
==========================================
  Files           4        4              
  Lines         387      402      +15     
==========================================
+ Hits          342      347       +5     
- Misses         45       55      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GunnarFarneback
Copy link
Collaborator Author

Julia nightly fails due to BFloat16s only working on nightly from 0.6.0 while some other compat keeps it down to 0.5.1. I think it's too early to worry about nightly considering that 1.12 was just released, and in any case that problem is unrelated to this PR.

@jw3126
Copy link
Owner

jw3126 commented Oct 14, 2025

Thanks LGTM.

@jw3126 jw3126 merged commit 8b28b4d into jw3126:main Oct 14, 2025
7 of 10 checks passed
@GunnarFarneback GunnarFarneback deleted the do_not_get_extension branch October 14, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants