feat(core): Add support for UPI #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #[derive(Default, Debug, Serialize, Deserialize, Clone)] | ||
| #[serde(rename_all = "snake_case")] | ||
| pub enum UpiAction { | ||
| #[default] |
There was a problem hiding this comment.
why is default required?
| authentication_channel, | ||
| }), | ||
| _ => { | ||
| // If the payment method is not card, we assume no authentication is required |
bsayak03
requested changes
Jun 10, 2025
| @@ -433,9 +441,9 @@ pub struct RazorpayPsyncResponse { | |||
| pub id: String, | |||
| pub entity: String, | |||
| pub amount: i64, | |||
| pub base_amount: i64, | |||
| pub base_amount: Option<i64>, | |||
There was a problem hiding this comment.
Can we not making this as MinorUnit?
ImSagnik007
force-pushed
the
upi_support
branch
2 times, most recently
from
f6291bf to
79d4488
Compare
| Ok(RazorpayPaymentRequest { | ||
| amount, | ||
| currency, | ||
| receipt: uuid::Uuid::new_v4().to_string(), |
There was a problem hiding this comment.
here we should use item.router_data.connector_request_reference_id instead of generating a random id as we will loose track of it.
| @@ -433,9 +451,9 @@ pub struct RazorpayPsyncResponse { | |||
| pub id: String, | |||
| pub entity: String, | |||
| pub amount: i64, | |||
There was a problem hiding this comment.
Suggested change
| pub amount: i64, | |
| pub amount: MinorUnit, |
| pub currency: String, | ||
| pub base_currency: String, | ||
| pub base_currency: Option<String>, |
There was a problem hiding this comment.
Suggested change
| pub base_currency: Option<String>, | |
| pub base_currency: Option<enums::Currency>, |
Make this change at all the places
| /// Frequency of the poll | ||
| pub frequency: u16, | ||
| } | ||
|
|
||
| #[derive(Debug, Default, Serialize, Deserialize)] | ||
| #[serde(rename_all = "snake_case")] | ||
| pub struct RazorpayErrorResponse { |
There was a problem hiding this comment.
Razorpay returns varying error formats (e.g. string or JSON), handle them using a enum.
| pub method: PaymentMethodType, | ||
| pub card: PaymentMethodSpecificData, | ||
| #[serde(flatten)] | ||
| pub payment_method_specific_data: PaymentMethodSpecificData, | ||
| pub authentication: Option<AuthenticationDetails>, | ||
| pub browser: Option<BrowserInfo>, | ||
| pub ip: String, |
There was a problem hiding this comment.
Suggested change
| pub ip: String, | |
| pub ip: Option<String>, |
referer and user_agent is also an optional field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for UPI
Motivation and Context
Additional Changes
How did you test it?
UPI Collect:
Response: